FancyInnovations/FancyPlugins
1
0
Fork 0
mirror of https://github.com/FancyInnovations/FancyPlugins.git synced 2025-12-06 07:43:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fn: Fix not trying to get username skins from cache first

Browse Source
This commit is contained in:
Oliver
2025-04-17 21:15:01 +02:00
parent 7726dc4af2
commit 723c3de3c4
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
plugins/fancynpcs/src/main/java/de/oliver/fancynpcs/skins/SkinManagerImpl.java
View File

@@ -72,13 +72,7 @@ public class SkinManagerImpl implements SkinManager, Listener {
return getByIdentifier(parsed, variant); return getByIdentifier(parsed, variant);
} }
// is username return getByUsername(identifier, variant);
UUID uuid = UUIDFetcher.getUUID(identifier);
if (uuid == null) {
throw new SkinLoadException(SkinLoadException.Reason.INVALID_USERNAME, "(USERNAME = '" + identifier + "')");
}
return getByUUID(uuid, variant);
} }
@Override @Override
@@ -98,12 +92,18 @@ public class SkinManagerImpl implements SkinManager, Listener {
@Override @Override
public SkinData getByUsername(String username, SkinData.SkinVariant variant) throws SkinLoadException { public SkinData getByUsername(String username, SkinData.SkinVariant variant) throws SkinLoadException {
SkinData cached = tryToGetFromCache(username, variant);
if (cached != null) {
return cached;
}
UUID uuid = UUIDFetcher.getUUID(username); UUID uuid = UUIDFetcher.getUUID(username);
if (uuid == null) { if (uuid == null) {
throw new SkinLoadException(SkinLoadException.Reason.INVALID_USERNAME, "(USERNAME = '" + username + "')"); throw new SkinLoadException(SkinLoadException.Reason.INVALID_USERNAME, "(USERNAME = '" + username + "')");
} }
SkinData dataByUUID = getByUUID(uuid, variant);
return getByUUID(uuid, variant); return new SkinData(username, dataByUUID.getVariant(), dataByUUID.getTextureValue(), dataByUUID.getTextureSignature());
} }
@Override @Override