From 8c98524d370eb3a148e5e28cfc91de153eea797a Mon Sep 17 00:00:00 2001 From: Oliver Date: Sat, 19 Jul 2025 20:31:03 +0200 Subject: [PATCH] fancyholograms v3: Mark methods as final in HologramTrait for immutability --- .../fancyholograms/api/trait/HologramTrait.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/plugins/fancyholograms/fh-api/src/main/java/de/oliver/fancyholograms/api/trait/HologramTrait.java b/plugins/fancyholograms/fh-api/src/main/java/de/oliver/fancyholograms/api/trait/HologramTrait.java index 63155b10..00ae0212 100644 --- a/plugins/fancyholograms/fh-api/src/main/java/de/oliver/fancyholograms/api/trait/HologramTrait.java +++ b/plugins/fancyholograms/fh-api/src/main/java/de/oliver/fancyholograms/api/trait/HologramTrait.java @@ -30,7 +30,8 @@ public abstract class HologramTrait { protected Hologram hologram; protected JDB storage; - public void attachHologram(Hologram hologram) { + @ApiStatus.Internal + public final void attachHologram(Hologram hologram) { if (this.hologram != null) { throw new IllegalStateException("Trait is already attached to a hologram"); } @@ -98,7 +99,7 @@ public abstract class HologramTrait { public void save() { } - public String getName() { + public final String getName() { if (getClass().isAnnotationPresent(HologramTraitClass.class)) { return getClass().getAnnotation(HologramTraitClass.class).traitName(); } @@ -106,7 +107,7 @@ public abstract class HologramTrait { throw new IllegalArgumentException("Trait class " + getClass() + " is not annotated with HologramTraitClass"); } - protected boolean isTraitAttached(Class trait) { + protected final boolean isTraitAttached(Class trait) { for (HologramTrait hologramTrait : hologram.getTraitTrait().getTraits()) { if (hologramTrait.getClass().equals(trait)) { return true; @@ -116,7 +117,7 @@ public abstract class HologramTrait { return false; } - protected T getTrait(Class trait) { + protected final T getTrait(Class trait) { for (HologramTrait hologramTrait : hologram.getTraitTrait().getTraits()) { if (hologramTrait.getClass().equals(trait)) { return (T) hologramTrait; @@ -126,7 +127,7 @@ public abstract class HologramTrait { return null; } - public Hologram getHologram() { + public final Hologram getHologram() { return hologram; } }